When to call validator in Symfony forms? - symfony

Question

I dont know when to call validation in this situation ? I made some constraints in Form/Model/User.php class for propertys, and don't know where to call it and how.And how to display errors on the same page.
What is best practice to do this right ?
public function userRegistrationAction(Request $request) {
$formUser = new FormUser();
$form = $this->createForm(UserType::class, $formUser);
$form->handleRequest($request);
if($form->isSubmitted() && $form->isValid()) {
$userEntity = new EntityUser();
$name = $form['name']->getData();
$surname = $form['surname']->getData();
$email = $form['email']->getData();
$password = $this->get('security.password_encoder')
->encodePassword($userEntity, $form['password']->getData());
$now = new\DateTime('now');
$userEntity->setName($name);
$userEntity->setSurname($surname);
$userEntity->setEmail($email);
$userEntity->setPassword($password);
$userEntity->setCreated($now);
$entityManager = $this->getDoctrine()->getManager();
$entityManager->persist($userEntity);
$entityManager->flush();
$request->getSession()
->getFlashBag()
->add('success', '- Success! ');
return $this->render('AppBundle:Welcome:homepage.html.twig', array(
'name' => $name,
'lastName' => $surname,
));
}

Answer 1

Did you created a formUser entity to fill a form then fill a user entity ? This make a lot of redundancies.
Your controller should looks like that:
<?php
public function userRegistrationAction(Request $request)
{
$userEntity = new EntityUser();
/*
You can directly provide your user entity to your form
There is no need to create a specific entity fir the form
*/
$form = $this->createForm(UserType::class, $userEntity);
$form->handleRequest($request);
/*
method isValid checks the form has been submitted so there
is no need to call isSubmitted by yourself
*/
if ($form->isValid()) {
/*
The password encryption part could be improved by
doing it outside of the controller
*/
$password = $this->get('security.password_encoder')
->encodePassword($userEntity, $userEntity->getPassword())
;
$userEntity->setPassword($password);
$entityManager = $this->getDoctrine()->getManager();
/*
By providing your user at your form at the begining all it
remains to do is persisting it and flush the manager
to insert it into your database.
*/
$entityManager->persist($userEntity);
$entityManager->flush();
$this->addFlash('success', '- Success! ');
return $this->render('AppBundle:Welcome:homepage.html.twig', array(
'name' => $name,
'lastName' => $surname,
));
}
return $this->render('AppBundle:User:userRegistration.html.twig', array(
'form' => $form->createView()
));
}
Now your form should look like that
<?php
class UserType extends AbstractType
{
/**
* #param FormBuilderInterface $builder
* #param array $options
*/
public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder
->add('name')
->add('surname')
->add('email')
->add('password', PasswordType::class)
->add('submit', SubmitType::class)
;
}
/**
* #param OptionsResolver $resolver
*/
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'data_class' => 'AppBundle\Entity\EntityUser',
));
}
/**
* #return string
*/
public function getName()
{
return 'user_type';
}
}
Your entity EntityUser
<?php
/**
* #ORM\HasLifecycleCallbacks()
*/
class EntityUser extends Entity
{
/**
* #ORM\PrePersist
*/
public function setCreatedAtValue()
{
/*
By using the PrePersist annotation you will automatically set
the createdAt property
*/
$this->createdAt = new \DateTime();
}
}
And finally your twig template
{# form_row is a shortcut to render at once
form_errors(form.field)
form_label(form.field)
form_widget(form.field)
so if you have errors on some of your fields there will be displayed #}
{{ form_start(form) }}
{{ form_row(form.name) }}
{{ form_row(form.surname }}
{{ form_row(form.email) }}
{{ form_row(form.password) }}
{{ form_row(form.submit) }}
{{ form_end(form) }}

Answer 2

OK, this was the problem: 'validation_groups' => ['registration'], i set this group for only one field, now i delete this and working nice, no need for callig validator after isValid.
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(array(
'validation_groups' => ['registration'], //delete this
'method' => 'post',
'data_class' => User::class,
'csrf_protection' => true,
'cascade_validation' => true
));
}